Move API stuff in ApiBundle #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests seems to failed because of a timeout.. I guess I'll wait for the #1166 to be merged (related to the fastest InstallCommand tests) |
j0k3r
force-pushed
the
v2-api-bundle
branch
2 times, most recently
from
fdf58fe
to
700d3e8
Compare
Of course, it breaks the url and the route matcher for each feed route
It takes ages to process and most of the time the build fail for "execution time" too long. Too much time already burned to investigate it. We'll investigate later, it's not a priority atm.
|
OK
I'll try again in a few days. |
|
@nicosomb FINALLY, good to merge 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep CoreBundle as the main one, ie: the one with entities, repositories, UI, etc ..
I've added more tests on the rest controller and fixed few things.