Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Material theme #1276

Merged
merged 2 commits into from
Aug 4, 2015
Merged

Added Material theme #1276

merged 2 commits into from
Aug 4, 2015

Conversation

modos189
Copy link
Contributor

@modos189 modos189 commented Aug 4, 2015

I added a new theme in the style of the Material Design. I would like to use a lot of aJax, but, as I understand, it does not support wallabag now.

@j0k3r
Copy link
Member

j0k3r commented Aug 4, 2015

Wow, lot of stuff.
Any screenshots?

@j0k3r
Copy link
Member

j0k3r commented Aug 4, 2015

Great! And I just noticed you pushed this new theme for the v2, excellent.

Could you update this screenshot src/Wallabag/CoreBundle/Resources/views/themes/material/screenshot.jpg according to your theme?

@j0k3r j0k3r added the UI label Aug 4, 2015
@j0k3r j0k3r added this to the 2.0 milestone Aug 4, 2015
@nicosomb
Copy link
Member

nicosomb commented Aug 4, 2015

\o/

material in config.yml is missing ;-)

<div id="main">
{% block menu %}
<nav class="cyan darken-1">
<ul style="width: 240px; left: 0px;" id="slide-out" class="side-nav fixed">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you avoid inline css and use the main.css instead?

@qwertygc
Copy link

qwertygc commented Aug 4, 2015

I love \o/ Just, for a better comfort of reading, it's a good idea to add : max-width:750px;

@modos189
Copy link
Contributor Author

modos189 commented Aug 4, 2015

Up

@qtheuret
Copy link
Contributor

qtheuret commented Aug 4, 2015

Very good theme.

@nicosomb
Copy link
Member

nicosomb commented Aug 4, 2015

I really love it, thank you very much.

Some notes, but I know all is not finished, it's just to not forget them.

  • When I save 10 articles, I've got 4 lines: 3 articles on 1st line, 3 on 2nd one, only 1 on 3rd line and 3 on last lines (chrome and firefox)
  • notifications when we star articles are buggy
  • footer is available even if I'm not logged, so the "about" link can't be accessible. I think the footer on login screen should be different.
  • is the login form not too big?
  • on mobile view (<= 768px), I can't see toolbar on article view.

I love the search engine, I love the article view, to put some information on footer is a very good idea ...

Good work!

I merge this PR, you can continue your work ;-)

nicosomb added a commit that referenced this pull request Aug 4, 2015
@nicosomb nicosomb merged commit 9e07dc9 into wallabag:v2 Aug 4, 2015
@nicosomb
Copy link
Member

nicosomb commented Aug 4, 2015

  • There are some references of baggy in material theme.
  • src/Wallabag/CoreBundle/Resources/views/base.html.twig has to be updated

@MrBoriska
Copy link

Yep! Yep! Good job!

@nicosomb
Copy link
Member

nicosomb commented Aug 4, 2015

Also, we wanted to add a preview of the article on homepage (with the first picture of the article, for example): can you try to see if it's possible to add a picture on each article (see #972).

@nicosomb nicosomb modified the milestones: 2.0, 2.0.0-alpha Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants