Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview picture for each article #972

Closed
nicosomb opened this issue Dec 18, 2014 · 12 comments
Closed

Preview picture for each article #972

nicosomb opened this issue Dec 18, 2014 · 12 comments
Labels
Milestone

Comments

@nicosomb
Copy link
Member

As @moafred (from Bookeen team) told me yesterday, we can use og:image meta to get a preview picture for each article.
This tag is used by twitter and facebook to generate preview in posts.

For example, with this article http://www.lemonde.fr/pixels/article/2014/12/18/affaire-sony-pictures-la-strategie-anti-piratage-d-hollywood-revelee_4542100_4408996.html, we have this meta :

<meta property="og:image" content="http://s1.lemde.fr/image/2014/12/17/600x315/4542146_3_8afb_le-legendaire-signe-surplombant-hollywood-en_443f1e6556ca1af14830f9d266203bcf.jpg" />

It can be useful for generating nice ePUB files (instead of wallabag logo).

@tcitworld Are you interested to have a look to this feature?

@tcitworld
Copy link
Member

Yup, seems quite good.

@tcitworld
Copy link
Member

To do :

  • look at how we can get the property information from fulltextrss class : extend Poche class ?
  • if Download pictures is activated, download...
  • integrate picture in themes ! (Pocket-like)
  • pass the link to epub generation

@nicosomb
Copy link
Member Author

We firstly need the last action in fact.
For the integration in the theme, we can wait. As you said in an other issue, we also have to think to the mobile view, etc.

@tcitworld tcitworld self-assigned this Dec 24, 2014
@tcitworld
Copy link
Member

I was looking if FTRSS already has something like that, but it doesn't seem so (I only looked the 3.2 version). The picture they produce comes only from pure RSS feeds (<itunes:image>, <atom:logo>, <atom:icon>, <image><title> or `dc:title) via Simple Pie, not regular html pages.
I could build the detection right in the makefulltextfeed.php file, or in wallabag itself. Are you interested, @fivefilters ?

@tcitworld
Copy link
Member

Wondering if it's better to extend the Readability class or the ContentExtrator one.

@fivefilters
Copy link

We don't do anything special with images at the moment. Might try to implement it at some point. Will most likely go into ContentExtractor rather than Readability. But also makes sense to have it in the Readability class.

By the way, might want to look at how the Newspaper project handles it - https://github.com/codelucas/newspaper/blob/74f349340391122cfd726eb2b049e109a9922c2c/newspaper/extractors.py#L298 - seems they look for the main image in the following order:

  1. <meta property="og:image" content="[URL]">
  2. <link rel="icon" href="[URL]">
  3. <link rel="img_src" href="[URL]">
  4. <meta name="og:image" content="[URL]">

Not sure why that particular order though...

@tcitworld
Copy link
Member

Thanks a lot for the link !
I'll start the work with the ContentExtractor class.

@nicosomb nicosomb mentioned this issue Feb 5, 2015
18 tasks
@j0k3r j0k3r added this to the 2.0 milestone Mar 4, 2015
@ghost ghost mentioned this issue Apr 19, 2015
This was referenced Aug 4, 2015
@nicosomb
Copy link
Member Author

for your information, @fivefilters implemented this feature in last version http://blog.fivefilters.org/post/121443274427/full-text-rss-35

@j0k3r
Copy link
Member

j0k3r commented Aug 17, 2015

This mean I need to add this feature to graby :)

@j0k3r
Copy link
Member

j0k3r commented Sep 12, 2015

Picture is now attached to each entry. We need to display it now.

@nicosomb
Copy link
Member Author

what do you think of this?

@j0k3r
Copy link
Member

j0k3r commented Sep 13, 2015

Great !

j0k3r added a commit that referenced this issue Sep 13, 2015
@j0k3r j0k3r closed this as completed Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants