-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview picture for each article #972
Comments
Yup, seems quite good. |
To do :
|
We firstly need the last action in fact. |
I was looking if FTRSS already has something like that, but it doesn't seem so (I only looked the 3.2 version). The picture they produce comes only from pure RSS feeds ( |
Wondering if it's better to extend the Readability class or the ContentExtrator one. |
We don't do anything special with images at the moment. Might try to implement it at some point. Will most likely go into ContentExtractor rather than Readability. But also makes sense to have it in the Readability class. By the way, might want to look at how the Newspaper project handles it - https://github.com/codelucas/newspaper/blob/74f349340391122cfd726eb2b049e109a9922c2c/newspaper/extractors.py#L298 - seems they look for the main image in the following order:
Not sure why that particular order though... |
Thanks a lot for the link ! |
for your information, @fivefilters implemented this feature in last version http://blog.fivefilters.org/post/121443274427/full-text-rss-35 |
This mean I need to add this feature to graby :) |
Picture is now attached to each entry. We need to display it now. |
Great ! |
As @moafred (from Bookeen team) told me yesterday, we can use og:image meta to get a preview picture for each article.
This tag is used by twitter and facebook to generate preview in posts.
For example, with this article http://www.lemonde.fr/pixels/article/2014/12/18/affaire-sony-pictures-la-strategie-anti-piratage-d-hollywood-revelee_4542100_4408996.html, we have this meta :
It can be useful for generating nice ePUB files (instead of wallabag logo).
@tcitworld Are you interested to have a look to this feature?
The text was updated successfully, but these errors were encountered: