Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #972: add preview pictures #1417

Merged
merged 2 commits into from
Sep 13, 2015
Merged

fix #972: add preview pictures #1417

merged 2 commits into from
Sep 13, 2015

Conversation

nicosomb
Copy link
Member

@nicosomb nicosomb added this to the 2.0.0-alpha.0 milestone Sep 12, 2015
@modos189
Copy link
Contributor

Wow! Good)

@modos189
Copy link
Contributor

I thing, better to use Card Reveal
http://materializecss.com/cards.html#reveal

@j0k3r
Copy link
Member

j0k3r commented Sep 12, 2015

What about baggy?

On 12 sept. 2015 13:44 +0200, Danilow Alexandrnotifications@github.com, wrote:

I thing, better to use Card Reveal
http://materializecss.com/cards.html#reveal

—
Reply to this email directly orview it on GitHub(#1417 (comment)).

@nicosomb
Copy link
Member Author

@j0k3r grrr forgot it!
@modos189 oh nice! thak you!

@nicosomb
Copy link
Member Author

@modos189 maybe can you do it please? you'll do it better than me.

@tcitworld
Copy link
Member

Pictures should stick to the bottom of the card, right ?

@nicosomb
Copy link
Member Author

what do you mean? No text (like action buttons) under the picture?

@tcitworld
Copy link
Member

Yup. If there's any text to show, show it above.
Just my opinion.

@tcitworld
Copy link
Member

(Referring to the third card)

@nicosomb
Copy link
Member Author

@modos189 it's a work for you!

@modos189
Copy link
Contributor

Ok

@nicosomb
Copy link
Member Author

Picture preview added on baggy theme.

@nicosomb
Copy link
Member Author

Maybe we can merge this 1st version of preview picture. Then @modos189 will enhance it.

@j0k3r
Copy link
Member

j0k3r commented Sep 13, 2015

Agreed.

j0k3r added a commit that referenced this pull request Sep 13, 2015
@j0k3r
Merge pull request #1417 from wallabag/v2-display-picture
4d5fd9b 
fix #972: add preview pictures
@j0k3r j0k3r merged commit 4d5fd9b into v2 Sep 13, 2015
@j0k3r j0k3r deleted the v2-display-picture branch September 13, 2015 09:41
@tcitworld tcitworld mentioned this pull request Sep 20, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@j0k3r j0k3r

Labels
Ready for review
Projects
None yet
Milestone
2.0.0-alpha.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicosomb @modos189 @j0k3r @tcitworld