Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage assets through npm #2103

Closed
wants to merge 1 commit into from
Closed

Manage assets through npm #2103

wants to merge 1 commit into from

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented May 19, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
Fixed tickets
License MIT

How it works now :
Run ./install.sh to run composer, npm, bower and grunt all in a row.

Still needs to be done :

  • Side-panels on material themes

composer install --no-interaction --no-progress --prefer-dist -o
else
echo "Installing PHP dependencies through Composer..."
composer install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you still do --no-interaction --no-progress --prefer-dist -o ?
Also, is it this command and user will run to install deps ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the user may prefer having the output of this command.

Yup, the user will just have to run ./install.sh. I can add the wallabag:install command to the script too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the composer install command should be SYMFONY_ENV=prod composer install --no-dev -o --prefer-dist.
But this shouldn't be that command for test & dev 😕

Should we have a install_dev.sh ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suits me.

@nicosomb
Copy link
Member

About MathJax, I think we can add it after this PR. What do you think about that?

@tcitworld
Copy link
Member Author

Yup, it's too foggy on how to find a good/modern method on how to handle it anyway.

@nicosomb
Copy link
Member

OK. About side panels, do you think you can do it soon?

@tcitworld
Copy link
Member Author

Will have a look over it over this week-end. Please test everything in meanwhile. ;-)

@tcitworld
Copy link
Member Author

Side panels are fixed by downgrading the materialize version.

first draft

remote assetic totally

work

nearly there

use at least nodejs > 0.12

use proper version of grunt

bump nodejs version for travis

update npm

workaround for materialize

install node 5.0

add grunt-cli

baggy theme & cache node modules

cache bower & npm

make travis build assets on php7 only

exclude installing node & npm if not needed & use bash

clean & try to make icomoon work on baggy

ready

config for travis

rebase

make travis work

more travis work

impove travis & update deps

add missing pixrem deps

add module through oddly lost

ui updates

install latest nodejs

add install_dev.sh, link local binaries for npm/bower/grunt

ui improvements (mostly baggy)

fix travis build

no need to install on travis

Add unread filter to entries pages

Add the ability to filter for unread pages in the filters menu.

Add unread filter test to EntryControllerTest

Add a new test to the EntryControllerTest collection which checks that
only entries which have not been archived (and are treated as "unread")
are retrieved.

Improve English translation

Update FAQ

-Fix grammar
-Add notes about MTA, firewall, and SELinux

Update installation instructions

-Fix grammar
-Add SELinux section

add screenshots of android docu in English

Fix the deletion of Tags/Entries relation when delete an entry
Fix #2121

Move fixtures to the right place

Display a message when saving an entry failed

When saving an entry fail because of database error we previously just returned `false`.
Now we got an error in the log and the displayed notice to the user is updated too.

Change ManyToMany between entry & tag

Following https://gist.github.com/Ocramius/3121916

Be sure to remove the related entity when removing an entity.

Let say you have Entry -> EntryTag -> Tag.
If you remove the entry:

 - before that commit, the EntryTag will stay (at least using SQLite).
 - with that commit, the related entity is removed

Prepare wallabag 2.0.5

enforce older materialize version
@tcitworld
Copy link
Member Author

And it's cleaned. :)

@tcitworld tcitworld closed this Jun 9, 2016
@tcitworld tcitworld mentioned this pull request Jun 9, 2016
1 task
@j0k3r j0k3r added this to the 2.1.0 milestone Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants