Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to check multiple urls in API #2393

Merged
merged 1 commit into from Oct 8, 2016
Merged

Ability to check multiple urls in API #2393

merged 1 commit into from Oct 8, 2016

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Oct 7, 2016 •
edited

Q A
Bug fix? no
New feature? yes (little one)
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
Fixed tickets #1796
License MIT

This is the end of #2325
We can now check multiple urls at once using:

/api/entries/exists?urls[]=http://...&urls[]=http://...

I don't know if we should put a limitation to avoid receiving hundred of urls at once ?

@j0k3r j0k3r added this to the 2.1.2 milestone Oct 7, 2016
@tcitworld
Copy link
Member

Seems good. What does @ThibaudDauce thinks ?

@ThibaudDauce
Copy link
Contributor

Seems good to me too! Thanks a lot!

@nicosomb nicosomb merged commit 4ad6f58 into master Oct 8, 2016
@nicosomb nicosomb deleted the api-urls-exist branch October 8, 2016 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

Assignees

@nicosomb nicosomb

@tcitworld tcitworld

Labels
Ready for review
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@j0k3r @tcitworld @ThibaudDauce @nicosomb