Add an exists endpoint in API #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should allow third party to check if an url was already saved by a user
nicosomb
reviewed
Oct 1, 2016
|
|
||
| $content = json_decode($this->client->getResponse()->getContent(), true); | ||
|
|
||
| $this->assertEquals(true, $content['exists']); |
There was a problem hiding this comment.
Is that necessary to add a test for inexistent entry?
There was a problem hiding this comment.
Well, yeah, there is never enough test :)
|
👍 |
Merged
|
Can this be improved to support arrays of urls liked @ThibaudDauce asked ? |
|
Yep it can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1796
It should allow third party to check if an url was already saved by a user