Save alpha channel when downloading PNG images #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2805 Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
j0k3r
approved these changes
Mar 30, 2017
There was a problem hiding this comment.
Apart from the copy/paste from the @tcitworld comment, I hope you really tested it 🐰
|
Haha, nice one. Yes I tested the change on two articles. However I didn't add any test to the test suite for that. |
|
Yeah it might be hard to add test for that case (how do you manage to check if the alpha is kept? by opening the image ..?) |
|
@wallabag/core I think that all our next PR should be merged into 2.3 branch. @Kdecherf thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save alpha channel when downloading PNG images
Fixes #2805