Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accessibility problem with the 2FA QR code #4915

Merged
merged 7 commits into from
Jan 18, 2021
Merged

Fix accessibility problem with the 2FA QR code #4915

merged 7 commits into from
Jan 18, 2021

Conversation

yannkozon
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
CHANGELOG.md no
License MIT

Fix accessibility problem :

  • constrast
  • label in header
  • alt for qrcode image

@j0k3r j0k3r added this to the 2.4.2 milestone Jan 8, 2021
j0k3r
j0k3r reviewed Jan 8, 2021
View reviewed changes
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, you can squash 👍

@j0k3r j0k3r changed the title Fix accessibility problem Fix accessibility problem with the 2FA QR code Jan 18, 2021
@j0k3r j0k3r merged commit a8db5b3 into wallabag:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r left review comments

@nicosomb nicosomb nicosomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@yannkozon @j0k3r @nicosomb