New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force secure cookie on HTTPS connection #6924

Merged

j0k3r merged 1 commit into 2.6 from fix/secure-cookie

Sep 6, 2023

Member

j0k3r commented Sep 6, 2023

Cookie will be set as secure when the connection will be on HTTPS otherwise the cookie will be defined as secure: false.

I used mkcert to test it locally.

See:

j0k3r added Security Ready for review labels

j0k3r added this to the 2.6.6 milestone

j0k3r requested review from nicosomb, Kdecherf and yguedidi

September 6, 2023 10:19

yguedidi requested changes

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

app/config/config.yml Outdated Show resolved Hide resolved


          Force secure cookie on HTTPS connection

c5d2102

j0k3r force-pushed the fix/secure-cookie branch from f523d2f to c5d2102 Compare

September 6, 2023 10:39

j0k3r requested a review from yguedidi

September 6, 2023 10:40

yguedidi approved these changes

View reviewed changes

j0k3r merged commit 62ab325 into 2.6

19 checks passed

j0k3r deleted the fix/secure-cookie branch

September 6, 2023 10:45

mweinelt added a commit to mweinelt/nixpkgs that referenced this pull request


          wallabag: 2.5.4 -> 2.6.6

ae4e973

https://github.com/wallabag/wallabag/releases/tag/2.6.0
https://github.com/wallabag/wallabag/releases/tag/2.6.1
https://github.com/wallabag/wallabag/releases/tag/2.6.2
https://github.com/wallabag/wallabag/releases/tag/2.6.3
https://github.com/wallabag/wallabag/releases/tag/2.6.4
https://github.com/wallabag/wallabag/releases/tag/2.6.5
https://github.com/wallabag/wallabag/releases/tag/2.6.6

Dropped the swiftmailer patch, because wallabag migrated to symfony
mailer.

GHSA-p8gp-899c-jvq9
GHSA-gjvc-55fw-v6vq
wallabag/wallabag#6924

Fixes: CVE-2023-4454, CVE-2023-4455

mweinelt added a commit to mweinelt/nixpkgs that referenced this pull request


          wallabag: 2.5.4 -> 2.6.6

0f9a86c

https://github.com/wallabag/wallabag/releases/tag/2.6.0
https://github.com/wallabag/wallabag/releases/tag/2.6.1
https://github.com/wallabag/wallabag/releases/tag/2.6.2
https://github.com/wallabag/wallabag/releases/tag/2.6.3
https://github.com/wallabag/wallabag/releases/tag/2.6.4
https://github.com/wallabag/wallabag/releases/tag/2.6.5
https://github.com/wallabag/wallabag/releases/tag/2.6.6

Dropped the swiftmailer patch, because wallabag migrated to symfony
mailer.

GHSA-p8gp-899c-jvq9
GHSA-gjvc-55fw-v6vq
wallabag/wallabag#6924

Fixes: CVE-2023-4454, CVE-2023-4455

github-actions bot pushed a commit to NixOS/nixpkgs that referenced this pull request


          wallabag: 2.5.4 -> 2.6.6

https://github.com/wallabag/wallabag/releases/tag/2.6.0
https://github.com/wallabag/wallabag/releases/tag/2.6.1
https://github.com/wallabag/wallabag/releases/tag/2.6.2
https://github.com/wallabag/wallabag/releases/tag/2.6.3
https://github.com/wallabag/wallabag/releases/tag/2.6.4
https://github.com/wallabag/wallabag/releases/tag/2.6.5
https://github.com/wallabag/wallabag/releases/tag/2.6.6

Dropped the swiftmailer patch, because wallabag migrated to symfony
mailer.

GHSA-p8gp-899c-jvq9
GHSA-gjvc-55fw-v6vq
wallabag/wallabag#6924

Fixes: CVE-2023-4454, CVE-2023-4455
(cherry picked from commit 0f9a86c)

ivandimitrov8080 pushed a commit to ivandimitrov8080/nixpkgs that referenced this pull request


          wallabag: 2.5.4 -> 2.6.6

2441bc0

https://github.com/wallabag/wallabag/releases/tag/2.6.0
https://github.com/wallabag/wallabag/releases/tag/2.6.1
https://github.com/wallabag/wallabag/releases/tag/2.6.2
https://github.com/wallabag/wallabag/releases/tag/2.6.3
https://github.com/wallabag/wallabag/releases/tag/2.6.4
https://github.com/wallabag/wallabag/releases/tag/2.6.5
https://github.com/wallabag/wallabag/releases/tag/2.6.6

Dropped the swiftmailer patch, because wallabag migrated to symfony
mailer.

GHSA-p8gp-899c-jvq9
GHSA-gjvc-55fw-v6vq
wallabag/wallabag#6924

Fixes: CVE-2023-4454, CVE-2023-4455

wegank pushed a commit to NixOS/nixpkgs that referenced this pull request


          wallabag: 2.5.4 -> 2.6.6

2390dbd

https://github.com/wallabag/wallabag/releases/tag/2.6.0
https://github.com/wallabag/wallabag/releases/tag/2.6.1
https://github.com/wallabag/wallabag/releases/tag/2.6.2
https://github.com/wallabag/wallabag/releases/tag/2.6.3
https://github.com/wallabag/wallabag/releases/tag/2.6.4
https://github.com/wallabag/wallabag/releases/tag/2.6.5
https://github.com/wallabag/wallabag/releases/tag/2.6.6

Dropped the swiftmailer patch, because wallabag migrated to symfony
mailer.

GHSA-p8gp-899c-jvq9
GHSA-gjvc-55fw-v6vq
wallabag/wallabag#6924

Fixes: CVE-2023-4454, CVE-2023-4455
(cherry picked from commit 0f9a86c)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment