Skip to content

Commit

Permalink
brainwallet: don't use Alert() to signal error, it was problematic fo…
Browse files Browse the repository at this point in the history
…r resetting page when changing currency
  • Loading branch information
MichaelMure committed Mar 19, 2014
1 parent e6dcb2d commit 73c1959
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -261,12 +261,13 @@
<span id="brainalgorithm" class="notes right">Algorithm: SHA256(passphrase)</span>
</div>
<div class="row extra"><span id="brainwarning"></span></div>
<div class="row extra"><span id="brainerror"></span></div>
</div>
<div id="brainkeyarea" class="keyarea">
<div class="public">
<div id="brainqrcodepublic" class="qrcode_public"></div>
<div class="pubaddress">
<span class="label" id="brainlabelbitcoinaddress">Bitcoin Address:</span>
<span class="label" id="brainlabelbitcoinaddress">Public Address:</span>
<span class="output" id="brainbtcaddress"></span>
</div>
</div>
Expand Down
6 changes: 4 additions & 2 deletions src/ninja.brainwallet.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ ninja.wallets.brainwallet = {
minPassphraseLength: 15,

view: function () {
document.getElementById("brainerror").innerHTML = "";

var key = document.getElementById("brainpassphrase").value.toString().replace(/^\s+|\s+$/g, ""); // trim white space
document.getElementById("brainpassphrase").value = key;
var keyConfirm = document.getElementById("brainpassphraseconfirm").value.toString().replace(/^\s+|\s+$/g, ""); // trim white space
Expand All @@ -33,12 +35,12 @@ ninja.wallets.brainwallet = {
document.getElementById("brainkeyarea").style.visibility = "visible";
}
else {
alert(ninja.translator.get("brainalertpassphrasetooshort") + ninja.translator.get("brainalertpassphrasewarning"));
document.getElementById("brainerror").innerHTML = ninja.translator.get("brainalertpassphrasetooshort");
ninja.wallets.brainwallet.clear();
}
}
else {
alert(ninja.translator.get("brainalertpassphrasedoesnotmatch"));
document.getElementById("brainerror").innerHTML = ninja.translator.get("brainalertpassphrasedoesnotmatch");
ninja.wallets.brainwallet.clear();
}
},
Expand Down

0 comments on commit 73c1959

Please sign in to comment.