This repository has been archived by the owner on Mar 20, 2021. It is now read-only.
Handle fetchQueue error for preempted requests #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a particular instance preempts a request round trip, the fetch queue can be left in an indeterminate state that can cause future requests to error out due to assumptions about the fetch queue’s contents. This change ensures that the fetchQueue is completely cleaned. Additionally it protects from NPEs that might occur due to preempted requests in promise supporting environments.
| @@ -398,6 +399,11 @@ function fetchQueue(options, $super) { | |||
| var index = _.indexOf(fetchQueue, this); | |||
| if (index >= 0) { | |||
| fetchQueue.splice(index, 1); | |||
|
|
|||
| // If we are the last of the fetchQueue entries, invalidate the queue. | |||
| if (!fetchQueue.length && fetchQueue === self.fetchQueue) { | |||
There was a problem hiding this comment.
When is fetchQueue !== self.fetchQueue?
There was a problem hiding this comment.
If the reset queue option is used then the fetchQueue object will be reset.
On Mon, Jun 9, 2014 at 12:17 PM, Roman Bataev notifications@github.com
wrote:
In src/loading.js:
@@ -398,6 +399,11 @@ function fetchQueue(options, $super) {
var index = _.indexOf(fetchQueue, this);
if (index >= 0) {
fetchQueue.splice(index, 1);
+
// If we are the last of the fetchQueue entries, invalidate the queue.if (!fetchQueue.length && fetchQueue === self.fetchQueue) {When is fetchQueue !== self.fetchQueue?
—
Reply to this email directly or view it on GitHub
https://github.com/walmartlabs/thorax/pull/373/files#r13552358.
|
+1 |
kpdecker
added a commit
that referenced
this pull request
Jul 7, 2014
Handle fetchQueue error for preempted requests
|
Released in 3.0.0-alpha.10 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a particular instance preempts a request round trip, the fetch queue can
be left in an indeterminate state that can cause future requests to error out
due to assumptions about the fetch queue’s contents.
This change ensures that the fetchQueue is completely cleaned. Additionally it
protects from NPEs that might occur due to preempted requests in promise
supporting environments.