Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User can view a list of reviews #3

Closed
walston opened this issue Feb 29, 2016 · 2 comments
Closed

User can view a list of reviews #3

walston opened this issue Feb 29, 2016 · 2 comments

Comments

@walston
Copy link
Owner

walston commented Feb 29, 2016

wireframe
Though this is issue #3), it is referenced in this image as 2) due to a previous issue filed.
walston pushed a commit that referenced this issue Feb 29, 2016
Roll updated so that user has a dynamically generated view populated …
ca7bba4 
…by an array of Review objects #3
walston pushed a commit that referenced this issue Feb 29, 2016
Corrected the way both the media is structured and the way it is serv…
b882eeb 
…ed to the DOM. Solved issue #3
@walston
Copy link
Owner Author

walston commented Mar 1, 2016

There's a bug in the way tags are displayed
var tagElement = document.createElement('span'); obj.tags.forEach( function (tag){ tagElement.appendChild(document.createTextNode(tag+' ')) this.appendChild(tagElement); }, tags);
a single tag element shouldn't contain all tags.

walston pushed a commit that referenced this issue Mar 1, 2016
issue #3: bug corrected regarding span.tag child elements under the p…
70f0702 
….tags; each tag is now semantically wrapped
@walston walston closed this as completed Mar 1, 2016
@walston
Copy link
Owner Author

walston commented Apr 14, 2016

User can see reviews by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@walston