Windows console logging fix (#170)

* fix windoows console logging

* format

* fix

* py27

* dont overwrite user val

* update env var in curr process

* cleanup

* fallback

* py27

* Dont set env var in setup.py

* rem unused import

* refac

* py27

* refac

* cleanup

* codemod fix

* rem prn

Co-authored-by: Jeff Raubitschek <jeff@wandb.com>

setup.py

@@ -4,6 +4,7 @@
 
 from setuptools import setup
 
+
 with open('package_readme.md') as readme_file:
     readme = readme_file.read()
 
@@ -77,3 +78,9 @@
         'grpc': grpc_requirements,
     }
 )
+
+# if os.name == "nt" and sys.version_info >= (3, 6):
+#     legacy_env_var = "PYTHONLEGACYWINDOWSSTDIO"
+#     if legacy_env_var not in os.environ:
+#         if os.system("setx " + legacy_env_var + " 1") != 0:
+#             raise Exception("Error setting environment variable " + legacy_env_var)

wandb/lib/redirect.py

@@ -124,6 +124,17 @@ def _redirect(self, to_fd, unbuffered=False, close=False):
             setattr(sys, self._stream, Unbuffered(getattr(sys, self._stream)))
 
     def install(self):
+        if self._installed:
+            return
+
+        if os.name == 'nt' and sys.version_info >= (3, 6):
+            legacy_env_var = 'PYTHONLEGACYWINDOWSSTDIO'
+            if legacy_env_var not in os.environ:
+                msg = "Set %s environment variable to enable"\
+                    " console logging on Windows." % legacy_env_var
+                logger.error(msg)
+                raise Exception(msg)
+
         logger.info("install start")
 
         fp = getattr(sys, self._stream)
@@ -142,10 +153,12 @@ def install(self):
         logger.info("install stop")
 
     def uninstall(self):
-        logger.info("uninstall start")
-        self._redirect(to_fd=self._old_fp.fileno(), close=True)
-        self._dest._stop()
-        logger.info("uninstall done")
+        if self._installed:
+            logger.info("uninstall start")
+            self._redirect(to_fd=self._old_fp.fileno(), close=True)
+            self._dest._stop()
+            self._installed = False
+            logger.info("uninstall done")
 
 
 class Capture(object):

wandb/sdk/wandb_run.py

@@ -886,7 +886,7 @@ def _redirect(self, stdout_slave_fd, stderr_slave_fd):
             self._out_redir = out_redir
             self._err_redir = err_redir
             logger.info("Redirects installed.")
-        except (OSError, AttributeError) as e:
+        except Exception as e:
             print(e)
             logger.error("Failed to redirect.", exc_info=e)
         return

wandb/sdk/wandb_settings.py

@@ -376,7 +376,17 @@ def _console(self) -> SettingsConsole:
             if self._jupyter:
                 console = "notebook"
             elif self._windows:
-                console = "notebook"
+                legacy_env_var = "PYTHONLEGACYWINDOWSSTDIO"
+                if sys.version_info >= (3, 6) and legacy_env_var not in os.environ:
+                    msg = (
+                        "Set %s environment variable to enable"
+                        " proper console logging on Windows. Falling "
+                        "back to monkey patching stdout/err." % legacy_env_var
+                    )
+                    logger.info(msg)
+                    console = "notebook"
+                else:
+                    console = "redirect"
             else:
                 console = "redirect"
         convert: SettingsConsole = convert_dict[console]

wandb/sdk_py27/wandb_run.py

@@ -886,7 +886,7 @@ def _redirect(self, stdout_slave_fd, stderr_slave_fd):
             self._out_redir = out_redir
             self._err_redir = err_redir
             logger.info("Redirects installed.")
-        except (OSError, AttributeError) as e:
+        except Exception as e:
             print(e)
             logger.error("Failed to redirect.", exc_info=e)
         return

wandb/sdk_py27/wandb_settings.py

@@ -376,7 +376,17 @@ def _console(self):
             if self._jupyter:
                 console = "notebook"
             elif self._windows:
-                console = "notebook"
+                legacy_env_var = "PYTHONLEGACYWINDOWSSTDIO"
+                if sys.version_info >= (3, 6) and legacy_env_var not in os.environ:
+                    msg = (
+                        "Set %s environment variable to enable"
+                        " proper console logging on Windows. Falling "
+                        "back to monkey patching stdout/err." % legacy_env_var
+                    )
+                    logger.info(msg)
+                    console = "notebook"
+                else:
+                    console = "redirect"
             else:
                 console = "redirect"
         convert = convert_dict[console]