This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
Windows console logging fix #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build de08e7e2-1640-444e-992d-2a61013a7be0
💛 - Coveralls |
raubitsj
suggested changes
Aug 28, 2020
There was a problem hiding this comment.
Based on the discussion at:
https://weightsandbiases.slack.com/archives/C0108SLEP6K/p1598636491077200
Lets:
- Do not automatically run the registry commands
- Try to use PYTHONLEGACYWINDOWSSTDIO
- and if it isnt set give a message to set the registry and set the environment
- automatically fall back to notebook console
|
I have a PR that cleans up the console settings to make this easier. Lets get that in first: |
raubitsj
suggested changes
Aug 31, 2020
wandb/sdk/wandb_run.py
Outdated
| ) | ||
| print(msg) | ||
| logger.info(msg) | ||
| console = self._settings.Console.NOTEBOOK |
There was a problem hiding this comment.
The decision of what console to use shouldnt be spread out among the code, it should in wandb_settings.py be at:
@Property
def _console(self) -> SettingsConsole:
raubitsj
approved these changes
Aug 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.