Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrations): add AttributeError to the list of handled exceptions when saving a keras model #4732

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

froody
Copy link
Contributor

@froody froody commented Jan 5, 2023

Description

Handle AttributeError throw by TF-2.11 in some cases when saving a model

Testing

Saving a model that uses mixed_float16 policy

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@morganmcg1
Copy link
Member

@froody , thanks for the PR. You mightn't have seen yet, but we have recently launched our v2 set of Keras callbacks which disaggregate the legacy callback and make logging to W&B more flexible. Would love to hear what you think:

https://docs.wandb.ai/guides/integrations/keras

WandbMetricsLogger : Use this callback for Experiment Tracking. It will log your training and validation metrics along with system metrics to Weights and Biases.

WandbModelCheckpoint : Use this callback to log your model checkpoints to Weight and Biases Artifacts.

WandbEvalCallback: This base callback will log model predictions to Weights and Biases Tables for interactive visualization.

@dmitryduev dmitryduev merged commit 361524c into wandb:main Jan 9, 2023
@dmitryduev dmitryduev added this to the sdk-2023-01.1 milestone Jan 9, 2023
kptkin pushed a commit that referenced this pull request Jan 10, 2023
…ras model (#4732)

Co-authored-by: Tom Birch <tom@powerlinespro.com>
@kptkin kptkin changed the title Add AttributeError to the list of handled exceptions when saving a keras model fix(integrations): add AttributeError to the list of handled exceptions when saving a keras model Jan 10, 2023
kptkin pushed a commit that referenced this pull request Jan 11, 2023
…ras model (#4732)

Co-authored-by: Tom Birch <tom@powerlinespro.com>
kptkin pushed a commit that referenced this pull request Jan 11, 2023
…ras model (#4732)

Co-authored-by: Tom Birch <tom@powerlinespro.com>
@froody froody deleted the tf211 branch January 11, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants