-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations): port OpenAI WandbLogger for openai-python v1.0 #6498
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6498 +/- ##
==========================================
- Coverage 79.48% 79.13% -0.35%
==========================================
Files 415 416 +1
Lines 47737 47958 +221
==========================================
+ Hits 37943 37953 +10
- Misses 9582 9790 +208
- Partials 212 215 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hey @kptkin, do let me know if anything else is needed from my end to get this PR merged? Also thanks for all the detailed feedback. |
Hey @kptkin, the PR is ready from my end. Do let me know if anything else is needed. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
What does the PR do?
This PR ports the the existing WandbLogger.sync() to wandb to make it work with openai v1.0.
The
WandbLogger
has the following features:During the rewrite of the
openai-python
repo, the authors had decided that this logger should live in the wandb python package instead of the openai package. Check out the discussion here.This PR ports the logic to this repo in the
from wandb.integration.openai import WandbLogger
namespace (subject to change). The implementation removes support for any openai legacy functionality and will work with v1.0.TODO:
🤖 Generated by Copilot at ce4ee24
This pull request adds a new module
wandb.integration.openai
that provides a classWandbLogger
to integrate wandb and openai fine-tuning. It also adds a test scripttest_openai_finetune.py
that uses the class to sync a specific fine-tuning job with wandb. The module and the script are commented and documented.Testing
How was this PR tested?
🤖 Generated by Copilot at ce4ee24