fix(sdk): report file upload failures as errors #7196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7196 +/- ##
==========================================
- Coverage 76.28% 76.23% -0.05%
==========================================
Files 509 509
Lines 54174 54180 +6
==========================================
- Hits 41325 41305 -20
- Misses 12499 12527 +28
+ Partials 350 348 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
moredatarequired
force-pushed
the
test-fault-uploads
branch
from
2784321
to
0048898
Compare
moredatarequired
changed the title
moredatarequired
changed the title
timoffex
requested changes
Mar 21, 2024
Co-authored-by: Timofey Peshin <timoffex@gmail.com>
Co-authored-by: Timofey Peshin <timoffex@gmail.com>
moredatarequired
force-pushed
the
test-fault-uploads
branch
from
5d10f80
to
892dcfe
Compare
1 task
timoffex
approved these changes
Apr 3, 2024
moredatarequired
force-pushed
the
test-fault-uploads
branch
from
63f320f
to
839ad03
Compare
timoffex
reviewed
Apr 4, 2024
kptkin
reviewed
Apr 5, 2024
| if err != nil { | ||
| return err | ||
| } else if resp == nil || resp.StatusCode < 200 || resp.StatusCode > 299 { | ||
| return fmt.Errorf("file transfer: upload: failed to upload: %v", resp.Status) |
There was a problem hiding this comment.
wait if resp is nil you will have a panic here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the
retryablehttp.Clientcompletes a request but the status code isn't 200, report the status as an error rather than returningnil.Testing
Added 4 tests for: