Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Upload tensorboard event files in core #7677

Conversation

timoffex
Copy link
Contributor

@timoffex timoffex commented May 20, 2024

Description

Implements watching and uploading tfevents files for TensorBoard.

Testing

  • Unit tests in tb_test.go
  • Manual repro as in WB-17261

Created using spr 1.3.5
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 56.66667% with 52 lines in your changes are missing coverage. Please review.

Please upload report for BASE (spr/timoffex/main.fixcore-upload-tensorboard-event-files-in-core@11f8b93). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                                         Coverage Diff                                         @@
##             spr/timoffex/main.fixcore-upload-tensorboard-event-files-in-core    #7677   +/-   ##
===================================================================================================
  Coverage                                                                    ?   73.08%           
===================================================================================================
  Files                                                                       ?      502           
  Lines                                                                       ?    54309           
  Branches                                                                    ?        0           
===================================================================================================
  Hits                                                                        ?    39693           
  Misses                                                                      ?    14192           
  Partials                                                                    ?      424           
Flag Coverage Δ
func 41.39% <ø> (?)
system 63.49% <12.50%> (?)
unit 52.15% <56.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/pkg/server/handler.go 69.71% <0.00%> (ø)
core/pkg/server/stream.go 95.89% <82.35%> (ø)
core/pkg/server/tb.go 57.62% <53.46%> (ø)

Created using spr 1.3.5
Created using spr 1.3.5
@timoffex timoffex marked this pull request as ready for review May 24, 2024 19:12
@timoffex timoffex requested a review from a team as a code owner May 24, 2024 19:12
@timoffex timoffex closed this May 28, 2024
@timoffex timoffex deleted the spr/timoffex/fixcore-upload-tensorboard-event-files-in-core branch June 6, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant