-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add weave to wandbot to track all intermediate steps and calls #76
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Hey @parambharat did you run eval on it? Do you want me to do it? |
@ayulockin , there are no functional changes other than adding weave ops and changing a few langchain imports to work with the new langchain version. I don't think a eval re-run might be necessary here. |
if chat_history is None: | ||
chat_history = [] | ||
|
||
with get_openai_callback() as query_enhancer_cb, Timer() as query_enhancer_tb: | ||
enhanced_query = self.query_enhancer.chain.invoke( | ||
enhanced_query = self.query_enhancer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the requirement of not doing .chain.invoke
a new thing in LECL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you have added __call__
methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, yes, this allows the use of a weave.op
decorator, making the weave integration easier.
Hey @parambharat, reviewed and it looks good. I asked a few questions out of curiosity. But going ahead and merging it. Thanks for the weave integration. |
The PR adds weave integration to wandbot to track RAG pipeline calls for query enhancements, retrieval, and response synthesis.