-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(weave): adding tooltip for overflowing text in modified dropdown #1659
Conversation
line-height: 1.2; | ||
} | ||
.menu .item { | ||
line-height: 1.2 !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need this to override the list of options line height for some reason
if (searchQuery) { | ||
return ''; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -460,3 +468,46 @@ const ModifiedDropdown: FC<ModifiedDropdownProps> = React.memo( | |||
); | |||
|
|||
export default ModifiedDropdown; | |||
|
|||
const OptionWithTooltip = ({text}: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: could we avoid the any
type here?
const OptionWithTooltip = ({text}: any) => { | |
const OptionWithTooltip = ({text}: {text: string}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responded to comments @connieelee, let me know if there are any more questions, thanks! |
@mbarrramsey lgtm! |
Jira: https://wandb.atlassian.net/browse/WB-14570
Adding a tooltip for overflowing text in the modified dropdown. This adds a tooltip if the selected option or list of options is overflowing.
Before
Screen.Recording.2024-05-17.at.11.40.58.AM.mov
After
Screen.Recording.2024-05-17.at.11.41.14.AM.mov
Screen.Recording.2024-05-17.at.11.42.17.AM.mov