chore(weave): adding tooltip for overflowing text in modified dropdown #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarrramsey
changed the title
mbarrramsey
commented
May 17, 2024
| line-height: 1.2; | ||
| } | ||
| .menu .item { | ||
| line-height: 1.2 !important; |
There was a problem hiding this comment.
Need this to override the list of options line height for some reason
connieelee
approved these changes
May 20, 2024
Comment on lines
+427
to
+429
| if (searchQuery) { | ||
| return ''; | ||
| } |
There was a problem hiding this comment.
question: what does this do?
There was a problem hiding this comment.
This makes the option hidden when the user is typing a search query to avoid both text showing up at once:
| @@ -460,3 +468,46 @@ const ModifiedDropdown: FC<ModifiedDropdownProps> = React.memo( | |||
| ); | |||
|
|
|||
| export default ModifiedDropdown; | |||
|
|
|||
| const OptionWithTooltip = ({text}: any) => { | |||
There was a problem hiding this comment.
suggestion: could we avoid the any type here?
Suggested change
| const OptionWithTooltip = ({text}: any) => { | |
| const OptionWithTooltip = ({text}: {text: string}) => { |
There was a problem hiding this comment.
Adding the string type but needed to cast as string due to the Option type having many possible types
|
Responded to comments @connieelee, let me know if there are any more questions, thanks! |
|
@mbarrramsey lgtm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://wandb.atlassian.net/browse/WB-14570
Adding a tooltip for overflowing text in the modified dropdown. This adds a tooltip if the selected option or list of options is overflowing.
Before
Screen.Recording.2024-05-17.at.11.40.58.AM.mov
After
Screen.Recording.2024-05-17.at.11.41.14.AM.mov
Screen.Recording.2024-05-17.at.11.42.17.AM.mov