Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number is too long error: fixed by using big integer in Jackson parser #38

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Number is too long error: fixed by using big integer in Jackson parser #38

merged 2 commits into from
Nov 25, 2021

Conversation

oleg-smith
Copy link
Contributor

No description provided.

@wanglingsong
Copy link
Owner

Could you please add an unit test for this change?

@oleg-smith
Copy link
Contributor Author

@wanglingsong sure, added

wanglingsong
wanglingsong requested changes May 31, 2018
View reviewed changes
Copy link
Owner

@wanglingsong wanglingsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move "testParsingLongIntegers" method into JacksonParserTest instead of creating new unit test class

@olddeer
Copy link

olddeer commented Apr 5, 2021

@wanglingsong Hello, I've faced same problems with "Number is too long for Long type", could you submit pull request ?

@wanglingsong wanglingsong mentioned this pull request Nov 8, 2021
Closed
@wanglingsong wanglingsong merged commit 4f2cb34 into wanglingsong:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanglingsong wanglingsong wanglingsong requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oleg-smith @wanglingsong @olddeer