Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add post_command feature to do some teardown work #71

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

debugtalk
Copy link
Contributor

@debugtalk debugtalk commented Jan 23, 2022

1, add post_command feature;
2, remove extra line suffix spaces by save config;
3, use RELEASE_ASSET_FILE to replace ${RELEASE_ASSET_NAME}${RELEASE_ASSET_EXT}

@wangyoucao577
Copy link
Owner

Overall it looks great! Thanks!
2, remove extra line suffix spaces by save config; How did you do that? By some plugin?

@wangyoucao577
Copy link
Owner

Overall it looks great! Thanks! 2, remove extra line suffix spaces by save config; How did you do that? By some plugin?

@debugtalk

@debugtalk
Copy link
Contributor Author

@wangyoucao577 configure in my vscode or IDE.

for example, you can set files.trimTrailingWhitespace in vscode.

@debugtalk
Copy link
Contributor Author

@wangyoucao577 Can this feature be merged and publish a new version?

@wangyoucao577 wangyoucao577 merged commit 2875b2d into wangyoucao577:master Jan 26, 2022
@wangyoucao577
Copy link
Owner

wangyoucao577 commented Jan 26, 2022

@wangyoucao577 Can this feature be merged and publish a new version?

@debugtalk Here you are: wangyoucao577/go-release-action@v1.23

@wangyoucao577 wangyoucao577 linked an issue Jan 26, 2022 that may be closed by this pull request
@debugtalk
Copy link
Contributor Author

@wangyoucao577 here is an example to use post_command

https://github.com/httprunner/hrp/blob/main/.github/workflows/release.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need post_command feature to do some teardown work
2 participants