Add support to produce zip files for all platforms #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyoucao577
reviewed
Sep 14, 2022
mjmayer
force-pushed
the
add_zip_flag
branch
from
5d81eac
to
1d1083f
Compare
mjmayer
force-pushed
the
add_zip_flag
branch
from
1d1083f
to
bdf1d7e
Compare
wangyoucao577
reviewed
Sep 15, 2022
mjmayer
force-pushed
the
add_zip_flag
branch
8 times, most recently
from
c8f4947
to
4166436
Compare
mjmayer
force-pushed
the
add_zip_flag
branch
from
4166436
to
e072596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
My use case might be an edge use case. I've written a AWS lambda in go and AWS expects the binary in a zip file format. This PR adds a flag
zip_assetswhich when true will produce zip files for both windows and Linux OS. Previous to this change only windows builds would produce a zip file, all others would get a tar.gz