Skip to content

Commit

Permalink
change BuildTime to BuildDuration
Browse files Browse the repository at this point in the history
Signed-off-by: wanjunlei <wanjunlei@kubesphere.io>
  • Loading branch information
wanjunlei committed Jun 25, 2023
1 parent 0de0379 commit fd732c7
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 26 deletions.
12 changes: 6 additions & 6 deletions apis/core/v1beta2/builder_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,11 @@ type BuilderOutput struct {

// BuilderStatus defines the observed state of Builder
type BuilderStatus struct {
Phase string `json:"phase,omitempty"`
State string `json:"state,omitempty"`
Reason string `json:"reason,omitempty"`
Message string `json:"message,omitempty"`
BuildTime *metav1.Duration `json:"buildTime,omitempty"`
Phase string `json:"phase,omitempty"`
State string `json:"state,omitempty"`
Reason string `json:"reason,omitempty"`
Message string `json:"message,omitempty"`
BuildDuration *metav1.Duration `json:"buildDuration,omitempty"`
// Associate resources.
ResourceRef map[string]string `json:"resourceRef,omitempty"`
// Output holds the results emitted from step definition of an output
Expand All @@ -182,7 +182,7 @@ type BuilderStatus struct {
//+kubebuilder:printcolumn:name="Phase",type=string,JSONPath=`.status.phase`
//+kubebuilder:printcolumn:name="State",type=string,JSONPath=`.status.state`
//+kubebuilder:printcolumn:name="Reason",type=string,JSONPath=`.status.reason`
//+kubebuilder:printcolumn:name="BuildTime",type=string,JSONPath=`.status.buildTime`
//+kubebuilder:printcolumn:name="BuildDuration",type=string,JSONPath=`.status.buildDuration`
//+kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"

// Builder is the Schema for the builders API
Expand Down
2 changes: 1 addition & 1 deletion apis/core/v1beta2/function_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ type Condition struct {
LastSuccessfulResourceRef string `json:"lastSuccessfulResourceRef,omitempty"`
ResourceHash string `json:"resourceHash,omitempty"`
Service string `json:"service,omitempty"`
BuildTime *metav1.Duration `json:"buildTime,omitempty"`
BuildDuration *metav1.Duration `json:"buildDuration,omitempty"`
}

type FunctionAddress struct {
Expand Down
8 changes: 4 additions & 4 deletions apis/core/v1beta2/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions config/bundle.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,8 @@ spec:
- jsonPath: .status.reason
name: Reason
type: string
- jsonPath: .status.buildTime
name: BuildTime
- jsonPath: .status.buildDuration
name: BuildDuration
type: string
- jsonPath: .metadata.creationTimestamp
name: Age
Expand Down Expand Up @@ -346,7 +346,7 @@ spec:
type: object
status:
properties:
buildTime:
buildDuration:
type: string
message:
type: string
Expand Down Expand Up @@ -9367,7 +9367,7 @@ spec:
type: array
build:
properties:
buildTime:
buildDuration:
type: string
lastSuccessfulResourceRef:
type: string
Expand Down Expand Up @@ -9460,7 +9460,7 @@ spec:
type: object
serving:
properties:
buildTime:
buildDuration:
type: string
lastSuccessfulResourceRef:
type: string
Expand Down
6 changes: 3 additions & 3 deletions config/crd/bases/core.openfunction.io_builders.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@ spec:
- jsonPath: .status.reason
name: Reason
type: string
- jsonPath: .status.buildTime
name: BuildTime
- jsonPath: .status.buildDuration
name: BuildDuration
type: string
- jsonPath: .metadata.creationTimestamp
name: Age
Expand Down Expand Up @@ -331,7 +331,7 @@ spec:
type: object
status:
properties:
buildTime:
buildDuration:
type: string
message:
type: string
Expand Down
4 changes: 2 additions & 2 deletions config/crd/bases/core.openfunction.io_functions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8193,7 +8193,7 @@ spec:
type: array
build:
properties:
buildTime:
buildDuration:
type: string
lastSuccessfulResourceRef:
type: string
Expand Down Expand Up @@ -8286,7 +8286,7 @@ spec:
type: object
serving:
properties:
buildTime:
buildDuration:
type: string
lastSuccessfulResourceRef:
type: string
Expand Down
6 changes: 3 additions & 3 deletions controllers/core/builder_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ func (r *BuilderReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
builder.Status.State = openfunction.Timeout
builder.Status.Reason = openfunction.Timeout
builder.Status.Message = openfunction.Timeout
builder.Status.BuildTime = builder.Spec.Timeout
builder.Status.BuildDuration = builder.Spec.Timeout

if err := r.Status().Update(r.ctx, builder); err != nil {
log.Error(err, "Failed to update builder status")
Expand Down Expand Up @@ -179,7 +179,7 @@ func (r *BuilderReconciler) getBuilderResult(builder *openfunction.Builder, buil
builder.Status.Reason = reason
builder.Status.Message = message
if !builder.CreationTimestamp.IsZero() {
builder.Status.BuildTime = &metav1.Duration{
builder.Status.BuildDuration = &metav1.Duration{
Duration: metav1.Now().UTC().Sub(builder.CreationTimestamp.UTC()).Truncate(time.Second),
}
}
Expand Down Expand Up @@ -257,7 +257,7 @@ func (r *BuilderReconciler) buildTimeout(builder *openfunction.Builder) error {
b.Status.State = openfunction.Timeout
b.Status.Reason = openfunction.Timeout
b.Status.Message = openfunction.Timeout
b.Status.BuildTime = builder.Spec.Timeout
b.Status.BuildDuration = builder.Spec.Timeout
return r.Status().Update(r.ctx, b)
}

Expand Down
4 changes: 2 additions & 2 deletions controllers/core/function_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ func (r *FunctionReconciler) createBuilder(fn *openfunction.Function) error {
fn.Status.Build.State = ""
fn.Status.Build.Reason = ""
fn.Status.Build.Message = ""
fn.Status.Build.BuildTime = nil
fn.Status.Build.BuildDuration = nil
fn.Status.Build.ResourceRef = ""
if err := r.Status().Update(r.ctx, fn); err != nil {
log.Error(err, "Failed to reset function build status")
Expand Down Expand Up @@ -259,7 +259,7 @@ func (r *FunctionReconciler) updateFuncWithBuilderStatus(fn *openfunction.Functi
fn.Status.Build.State = builder.Status.State
fn.Status.Build.Reason = builder.Status.Reason
fn.Status.Build.Message = builder.Status.Message
fn.Status.Build.BuildTime = builder.Status.BuildTime
fn.Status.Build.BuildDuration = builder.Status.BuildDuration
// If build had complete, update function serving status.
if builder.Status.State == openfunction.Succeeded {
if builder.Status.Output != nil {
Expand Down

0 comments on commit fd732c7

Please sign in to comment.