moved the copy of channel buffer to split since those are the buffers…

… we end up keeping
wanli · Mar 15, 2011 · dc4c16b · dc4c16b
1 parent a348c20
commit dc4c16b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...emcached/src/main/scala/com/twitter/finagle/memcached/protocol/text/AbstractDecoder.scala b/...emcached/src/main/scala/com/twitter/finagle/memcached/protocol/text/AbstractDecoder.scala
@@ -42,7 +42,7 @@ abstract class AbstractDecoder extends FrameDecoder {
     if (frameLength < 0) {
       needMoreData
     } else {
-      val frame = buffer.slice(buffer.readerIndex, frameLength).copy()
+      val frame = buffer.slice(buffer.readerIndex, frameLength)
       buffer.skipBytes(frameLength + DELIMITER.capacity)
 
       val tokens = frame.split(" ")

diff --git a/finagle-memcached/src/main/scala/com/twitter/finagle/memcached/util/ChannelBufferUtils.scala b/finagle-memcached/src/main/scala/com/twitter/finagle/memcached/util/ChannelBufferUtils.scala
@@ -19,10 +19,10 @@ object ChannelBufferUtils {
         val tokenLength = scratch.bytesBefore(stringToChannelBufferIndexFinder(delimiter))
 
         if (tokenLength < 0) {
-          tokens += scratch
+          tokens += scratch.copy
           scratch = scratch.slice(0, 0)
         } else {
-          tokens += scratch.slice(0, tokenLength)
+          tokens += scratch.slice(0, tokenLength).copy
           scratch = scratch.slice(tokenLength + skipDelimiter, scratch.capacity - tokenLength - skipDelimiter)
         }
       }