Drop dependency on AnyAscii for Lao transliteration #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wannaphong Please kindly release v1.1.2 to fix dependency issues for users. |
wannaphong
added a commit
that referenced
this pull request
Sep 23, 2023
- Drop dependency on AnyAscii for Lao transliteration #11 - Preserve terminal punctuation marks during sentence tokenization #12 - Fix most flake8 warnings #13 Thank you @BLKSerene !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the dependency on
AnyAsciifor the default engine of Lao transliteration. It also fixesModuleNotFoundErroronimport laonlpwhenAnyAsciiis not installed (import laonlpautomatically imports everything fromlaonlp.transliterate).The engine name is unchanged as the mapping table for Lao transliteration is simply copied from
AnyAscii.