Addition to make id input a bit safer

ward · Mar 25, 2010 · c5415b3 · c5415b3
1 parent 882585f
commit c5415b3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/jsfrontend/iplog.js b/jsfrontend/iplog.js
@@ -10,7 +10,7 @@ function getId() {
   return $.cookie('member_id');
 }
 function logUrl() {
-  return "http://home.wardje.eu/ip-2.0/ip.php";
+  return "URL HERE@@@@";
 }
 function createFrame(nick, id) {
   var frame = document.createElement('frame');
@@ -30,4 +30,4 @@ function setTtCookie(nick) {
 if (loggedIn() && $.cookie("ttip") != getNick()) {
   $("#gfooter").append(createFrame(getNick(), getId()));
   setTtCookie(getNick());
-}
+}
diff --git a/lib/db.php b/lib/db.php
@@ -52,8 +52,8 @@ function createTables() {
    * Insert a log into the database
    */
   function addLog($id, $name, $ip) {
-    self::updateName($id, $name);
-    self::updateIp($id, $ip);
+    self::updateName(intval($id), $name);
+    self::updateIp(intval($id), $ip);
   }
 
   /**
@@ -81,7 +81,7 @@ function updateName($id, $name) {
   function updateIp($id, $ip) {
     $insertQuery = sprintf("INSERT INTO iplogs (id, ip) VALUES (%s, '%s') ON DUPLICATE KEY UPDATE time=NULL",
                                 $id,
-                                $ip);
+                                mysql_real_escape_string($ip));
     mysql_query($insertQuery, $this->dblink);
     return mysql_affected_rows($this->dblink);
   }