Skip to content

Commit

Permalink
Improve the return value for cowboy_http_rest:upgrade/4
Browse files Browse the repository at this point in the history
  • Loading branch information
Loïc Hoguin committed Jan 23, 2012
1 parent 7482c0d commit 3078e94
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/cowboy_http_rest.erl
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@
%% You do not need to call this function manually. To upgrade to the REST
%% protocol, you simply need to return <em>{upgrade, protocol, {@module}}</em>
%% in your <em>cowboy_http_handler:init/3</em> handler function.
-spec upgrade(pid(), module(), any(), #http_req{}) -> {ok, #http_req{}}.
-spec upgrade(pid(), module(), any(), #http_req{})
-> {ok, #http_req{}} | close.
upgrade(_ListenerPid, Handler, Opts, Req) ->
try
case erlang:function_exported(Handler, rest_init, 2) of
Expand All @@ -73,7 +74,7 @@ upgrade(_ListenerPid, Handler, Opts, Req) ->
"** Request was ~p~n** Stacktrace: ~p~n~n",
[Handler, Class, Reason, Opts, Req, erlang:get_stacktrace()]),
{ok, _Req2} = cowboy_http_req:reply(500, Req),
ok
close
end.

service_available(Req, State) ->
Expand Down

0 comments on commit 3078e94

Please sign in to comment.