Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest Magepack version by default #712

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

sprankhub
Copy link
Contributor

Warden by default uses a very old Magepack version:

image: ${WARDEN_IMAGE_REPOSITORY}/magepack:${MAGEPACK_VERSION:-2.3}

We should at least propose using the newest version in the example .env file (if not bumping the default version).

@navarr navarr added this pull request to the merge queue Nov 22, 2023
Merged via the queue into wardenenv:main with commit 983cca5 Nov 22, 2023
@sprankhub sprankhub deleted the patch-2 branch November 22, 2023 18:27
@ihor-sviziev
Copy link
Contributor

@sprankhub don't you think that the default value should be also updated?

@sprankhub
Copy link
Contributor Author

@ihor-sviziev, I personally think so (I even suggested it above), but this would be kind of a breaking change 🤔

@navarr
Copy link
Member

navarr commented Dec 14, 2023

@ihor-sviziev @sprankhub It's a difficult question, which is why I've erred on the side of leaving it alone (for now).

I think at this point, nobody using Warden is expecting an undefined Magepack version to be the latest version. Such a change would really only benefit new users, while possibly being an unexpected change for older users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants