Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): Add initial integration tests #5

Merged
merged 3 commits into from
Feb 6, 2022

Conversation

m-rcd
Copy link
Collaborator

@m-rcd m-rcd commented Feb 5, 2022

Part of #4

1. Add FakeServer for Integration Tests

2. Add initial integration tests
Tested:
- Create without args
- Create with args name and namespace
- Get with args id
- List without args
- Delete with args id

@Callisto13 Callisto13 mentioned this pull request Feb 5, 2022
14 tasks
@Callisto13 Callisto13 changed the title Integration tests feat: Add initial integration tests Feb 5, 2022
@Callisto13 Callisto13 changed the title feat: Add initial integration tests feat(test): Add initial integration tests Feb 5, 2022
@Callisto13 Callisto13 self-requested a review February 5, 2022 17:51
@m-rcd m-rcd force-pushed the integration_tests branch 2 times, most recently from 3d184b6 to d87e920 Compare February 6, 2022 10:58
Copy link
Member

@Callisto13 Callisto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of small points

test/integration/integration_suite_test.go Outdated Show resolved Hide resolved
test/fakeserver/main.go Outdated Show resolved Hide resolved
test/integration/integration_suite_test.go Outdated Show resolved Hide resolved
Tested:
 - Create without args
 - Create with args name and namespace
 - Get with args id
 - List without args
 - Delete with args id
Copy link
Member

@Callisto13 Callisto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Callisto13 Callisto13 merged commit 664fe78 into warehouse-13:main Feb 6, 2022
@Callisto13 Callisto13 deleted the integration_tests branch February 6, 2022 12:37
@Callisto13 Callisto13 mentioned this pull request Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants