-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamically update max chars #51
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/warengonzaga/css-text-portrait-builder/AS1NRANCMXfsbfsaHX7B6QuX8DXZ |
Thanks for the PR @decanTyme! I'll review your update and provide feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All approved! Good move and nice implementing best practices.
Let's keep the comments in the JS file. It could help other users to understand the builder.
I'll note this also on the documentation. 😁
* Move `normalize.css` import to scss * Move main stylesheet import from js to html
Are you done with this? @decanTyme |
Yep. Already marked as ready. @warengonzaga |
Awesome, merging this now @decanTyme! Thanks for the awesome contributions! |
PR includes:
normalize.css
import to scssSummary:
Resolves issue #50:
Moved
main.scss
import since it's already bundled in a single stylesheet that can be put directly inside the html, and has no actual use in the js files aside for Parcel reference. Movednormalize.css
for better file hierarchy.Marked as draft since I have not actually tested it yet on other physical screens (only used the browser's devtools) and didn't test other fonts families/styles as well, so please feel free to test!