-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial support for exporting builds #52
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/warengonzaga/css-text-portrait-builder/2m2JDmfjbKKjzaqMSu29ysXQJYXw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me! I like what you did to export the builds by creating a post-build script. 😊
Meaning if you want to use parcel (zero-config) you still need to config it when you want to export a serverless version of your builds. 😅
The question, any instructions on how to export your builds? So I can add it to the official documentation. 🤔
* Add `jsdom` * Add postbuild script * Add npm scripts
Thanks! 😊 and yeah I really couldn't find anything anywhere that allows Parcel to bundle it for non-production settings, which I guess is understandable since it primarily deals with live apps and is created with that in mind.
Oh right almost forgot about this, thanks again for reminding! Docs:
Something like that I guess? |
That's it! We can improve it later... 😊 @decanTyme |
@decanTyme I'm happy to merge this now... |
PR Includes:
jsdom
Summary:
Adds initial support for exporting and compressing builds (#10). The exported files/zip should not require any server to run, which can then be easily shared.
Sidenote: removed
run
keyword from scripts since it is perfectly fine omitting it and it shortens some otherwise lengthy scripts.Sample compressed export: export.zip
Instructions/docs: