Skip to content

Commit

Permalink
autobuild.sh: Fix minor shell-quoting bugs.
Browse files Browse the repository at this point in the history
* autobuild.sh: Remove unnecessary quotes.
Don't choke on a file name argument containing a space.
Don't misbehave for $AUTOBUILD_INSTALL_ROOT containing
a shell meta-character.
  • Loading branch information
Jim Meyering committed Aug 21, 2008
1 parent e2d7a26 commit 7e0da18
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
8 changes: 8 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
Thu Aug 21 21:29:28 CEST 2008 Jim Meyering <meyering@redhat.com>

autobuild.sh: Fix minor shell-quoting bugs.
* autobuild.sh: Remove unnecessary quotes.
Don't choke on a file name argument containing a space.
Don't misbehave for $AUTOBUILD_INSTALL_ROOT containing
a shell meta-character.

Wed Aug 21 11:14:09 BST 2008 Daniel P. Berrange <berrange@redhat.com>

* src/remote_internal.c: Clarify error messages from various
Expand Down
8 changes: 4 additions & 4 deletions autobuild.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set -v

# Make things clean.

test -n "$1" && RESULTS="$1" || RESULTS="results.log"
test -n "$1" && RESULTS=$1 || RESULTS=results.log

test -f Makefile && make -k distclean || :
rm -rf coverage
Expand All @@ -14,7 +14,7 @@ rm -rf coverage
#mkdir build
#cd build

./autogen.sh --prefix=$AUTOBUILD_INSTALL_ROOT \
./autogen.sh --prefix="$AUTOBUILD_INSTALL_ROOT" \
--enable-test-coverage \
--enable-compile-warnings=error \
--with-openvz \
Expand All @@ -25,8 +25,8 @@ make
make install

set -o pipefail
make check 2>&1 | tee $RESULTS
make syntax-check 2>&1 | tee -a $RESULTS
make check 2>&1 | tee "$RESULTS"
make syntax-check 2>&1 | tee -a "$RESULTS"
test -x /usr/bin/lcov && make cov

rm -f *.tar.gz
Expand Down

0 comments on commit 7e0da18

Please sign in to comment.