Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split default overlays into discrete functionality #987

Open
1 task done
anderbubble opened this issue Nov 21, 2023 · 4 comments · May be fixed by #1306
Open
1 task done

split default overlays into discrete functionality #987

anderbubble opened this issue Nov 21, 2023 · 4 comments · May be fixed by #1306
Labels
enhancement New feature or request overlay Pertaining to the included Warewulf overlays stake:ciq CIQ is a stakeholder of this issue
Milestone

Comments

@anderbubble
Copy link
Collaborator

Summary

Split the generic and wwinit overlays into multiple discrete overlays based on their functionality. For example, wwinit might be split into NetworkManager, ifcfg, udev, etc.

These overlays should then be explicitly included by the default profile (not implicitly included by a built-in setting).

Rationale

The monolithic overlays make it difficult to opt-out of discrete parts of built-in Warewulf functionality.

Description

No response

Additional information

No response

General information

  • I have searched the issues of this repo and believe this is not a duplicate
@anderbubble anderbubble added enhancement New feature or request discuss A topic for discussion in a community meeting labels Nov 21, 2023
@blixuga
Copy link

blixuga commented Nov 22, 2023

Assuming that #885 is going to be a prerequisite for this?

@anderbubble
Copy link
Collaborator Author

Assuming that #885 is going to be a prerequisite for this?

Not specifically, though #885 will probably be merged in first anyway. (I just haven't gotten to it.)

@anderbubble anderbubble added this to the 4.6.0 milestone Nov 22, 2023
@anderbubble anderbubble removed the discuss A topic for discussion in a community meeting label Nov 22, 2023
@anderbubble anderbubble added the stake:ciq CIQ is a stakeholder of this issue label Mar 19, 2024
@griznog
Copy link
Contributor

griznog commented Apr 30, 2024

I've been thinking about this quite a bit, encouraged my my ongoing experiment of multiple clusters/sites sharing a base set of overlays and today @anderbubble 's comment in #1208 sparked an idea. I'm now thinking:

  • Warewulf distributed overlays go into /usr/share/warewulf/overlays.
  • User defined overlays and modifications go into /etc/warewulf/overlays.
  • A user overlay of the same name as a Warewulf Overlay overrides the warewulf overlay file-by-file during overlay building.

Under this arrangement if I only want to modify one file in the upstream overlay ANOVERLAY, I'd create /etc/warewulf/overlays/ANOVERLAY and put only my modifications in there, leaving the rpm-delivered overlay untouched. Locally defined overlays just need to not conflict with names of warewulf provided overlays, which could be addressed by prefix/suffix on warewulf provided overlay names.

I think this would allow easy locally managed revision control for /etc/warewulf/overlays with just modifications to standard overlays and custom local overlays in this location. rpm/dpkg updates could optionally run a script to warn if an updated file is also present in the local overlay location. Bonus of this rolling overlays into any revision control already in use in /etc/warewulf.

griznog

@anderbubble
Copy link
Collaborator Author

I 100% agree with @griznog.

@anderbubble anderbubble added the overlay Pertaining to the included Warewulf overlays label Jun 9, 2024
anderbubble added a commit to anderbubble/warewulf that referenced this issue Jul 15, 2024
- Closes warewulf#987

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
@anderbubble anderbubble linked a pull request Jul 15, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request overlay Pertaining to the included Warewulf overlays stake:ciq CIQ is a stakeholder of this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants