Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download rendered overlays via http #815

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mslacken
Copy link
Member

Adds a simple http server on the warewulf port which is rooted at
the $OVERLAYIDR/wwwroot/. Files with the .ww suffix are rendered as
templates where the node can be set via the ?node=$NODE parameter.

@mslacken
Copy link
Member Author

depends on #786 in order to compile

@anderbubble
Copy link
Collaborator

Is there any security on this? Similar to the secure: true function, I would want to see a way to prevent regular users from accessing arbitrary overlays and, perhaps, to prevent nodes from seeing each other's overlays.

@mslacken
Copy link
Member Author

mslacken commented May 12, 2023

Is there any security on this? Similar to the secure: true function, I would want to see a way to prevent regular users from accessing arbitrary overlays and, perhaps, to prevent nodes from seeing each other's overlays.

For the actual implementation only files which are under $WWOVERLYADIR/wwwroot are delivered. Also the secure port is honored.

@griznog
Copy link
Contributor

griznog commented May 24, 2023

Curious what does this add we didn't already have by just pulling overlays from the warewulfd port directly?

@mslacken
Copy link
Member Author

Curious what does this add we didn't already have by just pulling overlays from the warewulfd port directly?

At the moment we are pulling a cpio archive of all files in the overlay. This will allow us to pull a single file from an overlay which than can be used as configuration file for e.g. cloud-init.

@anderbubble anderbubble added this to the 4.6.0 milestone Sep 27, 2023
@anderbubble anderbubble added the discuss A topic for discussion in a community meeting label Sep 27, 2023
@anderbubble anderbubble changed the base branch from development to main November 23, 2023 18:41
@griznog
Copy link
Contributor

griznog commented Mar 6, 2024

I think I'd like an option to serve static files through warewulfd but every time I think about what I'd do with it all I can come up with are bad ideas that I don't think I should do. Could the class of use cases like cloud-init be better solved by moving all cloud-init (or whatever) files into a dedicated overlay so the smaller and more focused overlay could be pulled as a complete entity as proposed in #987

@mslacken mslacken mentioned this pull request May 8, 2024
8 tasks
Signed-off-by: Christian Goll <cgoll@suse.de>
Signed-off-by: Christian Goll <cgoll@suse.de>
@anderbubble anderbubble added overlay Pertaining to the included Warewulf overlays warewulfd labels Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss A topic for discussion in a community meeting overlay Pertaining to the included Warewulf overlays warewulfd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants