Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG 🐞] Outlines are not visible in dark mode #79

Closed
warmachine028 opened this issue Oct 2, 2023 · 7 comments · Fixed by #81
Closed

[BUG 🐞] Outlines are not visible in dark mode #79

warmachine028 opened this issue Oct 2, 2023 · 7 comments · Fixed by #81
Assignees
@a-s-t-e-y-a
Labels
enhancement Improvement to a feature 🛠 goal: fix good first issue The issue is to encourage first time contributors hacktoberfest This issue/pull request is specially marked for hacktoberfest

Comments

@warmachine028
Copy link
Owner

Description

  • The form outlines are not visible in dark mode for SignIn and SignUp forms
  • Do not change anything for Default mode, only change it for Dark (Light)
  • You can take reference from the Form.jsx component styles.

Screenshots

Screenshot_2023-10-02-20-50-33-091_com android chrome

  • Supposed to look similar to this
    Screenshot_2023-10-02-21-03-29-175_com android chrome

Additional information

  • Always use styled components instead of plain CSS and MUI components.

Make sure to read the CONTRIBUTING and SETUP docs before proceeding

Happy contributing. 💐

Star my other Repositories here
@warmachine028 warmachine028 added bug enhancement Improvement to a feature help wanted good first issue The issue is to encourage first time contributors 🤩 Up for the grab The issue is ready to be assigned to a contributor 🛠 goal: fix labels Oct 2, 2023
@RacHiT101
Copy link

hey @warmachine028 can u assign this to me ?

@warmachine028
Copy link
Owner Author

Sure assigning you

a-s-t-e-y-a added a commit to a-s-t-e-y-a/memories that referenced this issue Oct 2, 2023
@a-s-t-e-y-a
warmachine028#79 bug Fixed :Outlines are not visible in dark mode are…
e6575c7 
… fixed
@a-s-t-e-y-a a-s-t-e-y-a mentioned this issue Oct 2, 2023
Merged
2 tasks
@a-s-t-e-y-a
Copy link
Contributor

Hi @warmachine028,

I've generated a PR to address the issue at hand. You can find it here.

Please review the changes made in the PR, and if it aligns with your requirements, kindly consider merging it. If there are any reasons for not merging it, please provide feedback so that I can make the necessary adjustments.

Thank you for your time and attention to this matter.

Best regards,
krishna seth

@warmachine028
Copy link
Owner Author

Hi @warmachine028,

I've generated a PR to address the issue at hand. You can find it here.

Please review the changes made in the PR, and if it aligns with your requirements, kindly consider merging it. If there are any reasons for not merging it, please provide feedback so that I can make the necessary adjustments.

Thank you for your time and attention to this matter.

Best regards, krishna seth

  • You must have gotten assigned to this issue before proceeding, someone was already working on it.
  • I won't close your PR right now, since I know you have put efforts.
  • I would wait for @RacHiT101 till tomorrow, if he is unable to solve it by then, I will assign you to it.
  • Then I will review and request necessary changes if needed.
  • Add hacktoberfest-accepted tags and merge the PR.

a-s-t-e-y-a added a commit to a-s-t-e-y-a/memories that referenced this issue Oct 2, 2023
@a-s-t-e-y-a
warmachine028#79 bug Fixed :Outlines are not visible in dark mode are…
a503a01 
… fixed
@RacHiT101 RacHiT101 mentioned this issue Oct 2, 2023
Closed
2 tasks
@warmachine028
Copy link
Owner Author

@a-s-t-e-y-a I have assigned you to this issue

@a-s-t-e-y-a
Copy link
Contributor

@warmachine028 Thanks
I'll make the changes you asked

a-s-t-e-y-a added a commit to a-s-t-e-y-a/memories that referenced this issue Oct 2, 2023
@a-s-t-e-y-a
warmachine028#79 bug Fixed :Outlines are not visible in dark mode are…
75ab9ab 
… fixed
@warmachine028 warmachine028 added hacktoberfest This issue/pull request is specially marked for hacktoberfest and removed help wanted 🤩 Up for the grab The issue is ready to be assigned to a contributor labels Oct 2, 2023
@a-s-t-e-y-a
Copy link
Contributor

@warmachine028 I fix the issue that you stated
Kindly review the PR

a-s-t-e-y-a added a commit to a-s-t-e-y-a/memories that referenced this issue Oct 2, 2023
@a-s-t-e-y-a
warmachine028#79 bug Fixed :Outlines are not visible in dark mode are…
9013191 
… fixed
warmachine028 added a commit that referenced this issue Oct 2, 2023
@warmachine028
Merge pull request #81 from a-s-t-e-y-a/main
7bfa199 
#79 bug Fixed :Outlines are not visible in dark mode are fixed
@warmachine028 warmachine028 mentioned this issue Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-s-t-e-y-a a-s-t-e-y-a

Labels
enhancement Improvement to a feature 🛠 goal: fix good first issue The issue is to encourage first time contributors hacktoberfest This issue/pull request is specially marked for hacktoberfest
Projects
memories 💻📱
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: outlines are not visible in dark mode are fixed a-s-t-e-y-a/memories
Fix/outine form
3 participants
@warmachine028 @a-s-t-e-y-a @RacHiT101