Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outlines are not visible in dark mode are fixed #81

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

a-s-t-e-y-a
Copy link
Contributor

@a-s-t-e-y-a a-s-t-e-y-a commented Oct 2, 2023

Issue #79 📐

Guidelines 🔐

I accept the fact that I have followed the guidelines and have not copied the codes from around the internet

  • Contribution Guidelines
  • Code of Conduct

Issue to be closed 🛅

Screenshots 📷

Here are the pictures of changes that I have made 🔽

image


@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
memories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 6:49pm
memories-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 6:49pm

@vercel
Copy link

vercel bot commented Oct 2, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @warmachine028 on Vercel.

@warmachine028 first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @a-s-t-e-y-a, thank you for raising a pull request.

Please make sure you have filled the PR template properly and followed our contributing guidelines.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations 🎉 @a-s-t-e-y-a, on your first contribution in memories

  • Make sure to star this project, if you liked contributing to it. 🌟🌟🌟
  • You can raise another new issue, if you find something is worth enhancement or needs a fix.
  • You can see my other projects too, which you might feel appealing.
  • You also follow me for making more future contributions in open-source projects.

@warmachine028 warmachine028 reopened this Oct 2, 2023
@github-actions github-actions bot added hacktoberfest This issue/pull request is specially marked for hacktoberfest 🛠 goal: fix 🐞 bug Something isn't working labels Oct 2, 2023
Copy link
Owner

@warmachine028 warmachine028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

fix this for light mode. It should look like below
image

@a-s-t-e-y-a
Copy link
Contributor Author

@warmachine028 okay I'll try to fix this

Copy link
Owner

@warmachine028 warmachine028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This changes are still not like before in the light mode
  • You can refer to the actual deployed site for the original view.
  • There was no shadow in the input

image

@a-s-t-e-y-a
Copy link
Contributor Author

@warmachine028 Please review the latest commit again

@warmachine028
Copy link
Owner

@warmachine028 Please review the latest commit again

Perfect! You have solved a big issue. Merging it now

@warmachine028 warmachine028 merged commit 7bfa199 into warmachine028:main Oct 2, 2023
6 checks passed
@warmachine028 warmachine028 added the hacktoberfest-accepted The contribution was accepted for hactoberfest label Oct 2, 2023
@warmachine028 warmachine028 changed the title #79 bug Fixed :Outlines are not visible in dark mode are fixed fux: outlines are not visible in dark mode are fixed Oct 6, 2023
@warmachine028 warmachine028 changed the title fux: outlines are not visible in dark mode are fixed fix: outlines are not visible in dark mode are fixed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🛠 goal: fix hacktoberfest This issue/pull request is specially marked for hacktoberfest hacktoberfest-accepted The contribution was accepted for hactoberfest UI/UX 🖍️
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG 🐞] Outlines are not visible in dark mode
2 participants