Unconfirmed user #354
Closed
Unconfirmed user #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not confirmed yet. `403 Forbidden` and `500 Internal server error` responses are handled for loading users on a Map and loading threads of Messages. Accordingly `access_denied` and `internal_server_error` strings are added to the resources.
… is not confirmed yet. `403 Forbidden` and `500 Internal server error` responses are handled for searching for users.
…icable. This way HttpErrorHelper can differentiate exception handling behaviour based on the exception type.
Single quotes instead of double quotes resulted in WS_API_USER_ID and WS_API_KEY being set to variable names instead of the variables' contents.
The automatic message reloading was not working properly, especially after a reboot of the device. This also increases the default reload interval to 15 minutes.
Co-authored-by: Simone <cioccasimone97@users.noreply.github.com> Co-authored-by: Jakob <jakobhanna@users.noreply.github.com> Closes: warmshowers#353
Adjusted the TravisCI deploy script to monitor the new location of the deobfuscation file.
…ad_create_failed and messages_reload_failed)
…t they were doing so instead of simple failure message may be more interested in what actually went wrong. Remove message_send_failed from the resources as it is not used anywhere any more.
|
Hey @saemy, it should be good for the review. I thought I rebased my branch on |
|
Please disregard this PR, I created #355 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user creates an account the e-mail address they provided needs to be verified. Util they confirm, they can log in but they don't have access to most resources so the server returns 403 errors. I changed the code so that they get a message with some hints what is going on. This solves #327.
This could happen when loading users on the Map, Searching for specific users or checking Messages. I updated all these places. We might also consider sending a request to check permissions when user logs in for the first time on the device (seems for me more intuitive).
I added filtering to exception handling. It is based on http error codes, so that:
403 Forbiddenresponse results in returningaccess_deniedstring from the resources (added), mapped toAccess denied. Please check your email for account confirmation message. (proposition)
500 Internal server errorresponse results in returninginternal_server_errorstring (added), mapped toOops... This is on us, sorry! Something has gone wrong on the server side. Please try again later.
Also:
message_thread_create_failed,messages_reload_failedandmessage_send_failedare not used anywhere any more so I removed themI was thinking of changing error handling, moving towards having one place where different exception types and http error codes are translated to messages and displayed, so that it is more uniform across that app and we could easily hook some more robust logging/analytics. So far I started to placed it in
HttpErrorHelper. And I changedErrors toHttpExceptions where applicable so we could differentiate exception handling behavior based on ex type and error code.I tried (quite hard) to write tests for my changes, gave up with threads though. I still hope to come back to it later.