fix: a11y issues for expandable #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you are using tabs instead of spaces for indentation? 😅 |
BalbinaK
reviewed
Oct 25, 2023
packages/expandable/src/props.tsx
Outdated
| * The state of the chevron-up icon, if set to true, chevron up should be displayed, if set to false then chevron-down icon should be displayed. | ||
| * @default false | ||
| */ | ||
| showChevronUpIcon?: boolean; |
There was a problem hiding this comment.
Why can't we use expanded for that purpose? If it's true, chevron down should be displayed and the opposite.
There was a problem hiding this comment.
I tried that. It displays the chevron down and vs. but the animation doesn't work then. That's why I added the showChevronUpIcon-prop. I also added it as a prop because I saw that we had an example in the expandable story "Animated Expanded" where we wanted the Expandable-component to already be expanded. :)
|
BalbinaK
reviewed
Oct 25, 2023
BalbinaK
approved these changes
Oct 25, 2023
BalbinaK
reviewed
Oct 25, 2023
BalbinaK
approved these changes
Oct 25, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
## [1.1.2-next.6](v1.1.2-next.5...v1.1.2-next.6) (2023-10-26) ### Bug Fixes * a11y issues for expandable ([#138](#138)) ([ff8fecc](ff8fecc))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
# [1.2.0](v1.1.1...v1.2.0) (2023-11-06) ### Bug Fixes * a11y adjust attention ([#127](#127)) ([6fba30c](6fba30c)) * a11y fixes for select component ([#146](#146)) ([d4d8c18](d4d8c18)) * a11y issues for expandable ([#138](#138)) ([ff8fecc](ff8fecc)) * activate translations in steps ([#144](#144)) ([8eb603e](8eb603e)) * add a11y attributes for to define steps in more accessible way ([#140](#140)) ([47af229](47af229)) * Add role property to Box component ([#139](#139)) ([e46db48](e46db48)) * adjust further a11y issues attention ([#147](#147)) ([b668aeb](b668aeb)) * crowdin build step ([#142](#142)) ([f2ace37](f2ace37)) ### Features * **attention:** add close button ([#149](#149)) ([6a5c9d6](6a5c9d6)) * **attention:** add highlight variant ([#145](#145)) ([1b86124](1b86124))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a11y issues for expandable component in WARP-326 :
<h2>instead of a<h1>