fix: Import icons in the correct way #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Shouldn't this wait until there is a stable new release of icons and use that instead of the latest next-release? I thought we were supposed to avoid adding the "-next" releases to our component-repos, but maybe I've minsunderstood that. :) |
felicia-haggqvist
approved these changes
Nov 23, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
## [1.2.1-next.3](v1.2.1-next.2...v1.2.1-next.3) (2023-11-23) ### Bug Fixes * Import icons in the correct way ([#169](#169)) ([f279db9](f279db9))
BalbinaK
reviewed
Nov 23, 2023
|
Ah, the |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
## [1.2.1](v1.2.0...v1.2.1) (2023-11-29) ### Bug Fixes * **combobox:** don't open on modifier key press and fix aria-expanded ([#152](#152)) ([71e42f6](71e42f6)) * Import icons in the correct way ([#169](#169)) ([f279db9](f279db9)) * **textfield:** allow styling input's left padding when prefix is wider than 40px ([#173](#173)) ([89e5a27](89e5a27)) * **textfield:** render prefix before input ([#161](#161)) ([2017cff](2017cff))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to importing individual icons since that was polluting the bundle. But this is just step 1. It might be that we need to publish individual exports like we do in elements repo.
Currently using icons:
1.3.0-next.2