Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copying a link will make a copy of the file pointed by the link #91

Closed
warpdesign opened this issue Nov 17, 2019 · 0 comments · Fixed by #129
Closed

Copying a link will make a copy of the file pointed by the link #91

warpdesign opened this issue Nov 17, 2019 · 0 comments · Fixed by #129
Labels
Filesystem invalid This doesn't seem right macOS
Milestone
release 2.3.0

Comments

@warpdesign
Copy link
Owner

warpdesign commented Nov 17, 2019 •
edited
Loading

On macOS (Catalina), when copying a link pointing to a file, a copy of the target is actually created.

Expected: a new link pointing to the same file should be created.
@warpdesign warpdesign added invalid This doesn't seem right macOS Filesystem labels Nov 17, 2019
@warpdesign warpdesign added this to the release 2.2.1 milestone Nov 17, 2019
@warpdesign warpdesign added invalid This doesn't seem right and removed invalid This doesn't seem right labels Mar 23, 2020
warpdesign added a commit that referenced this issue Apr 14, 2020
@warpdesign
FIXED: when copying a link, copy target, not file, fixes #91
9d13727 
CLEANED-UP: removed not needed promise wrappers
@warpdesign warpdesign mentioned this issue Apr 17, 2020
Merged
warpdesign added a commit that referenced this issue Apr 17, 2020
@warpdesign
Fix copy symlink (#129)
1510947 
* FIXED: show error message when shell.openItem returns false
* IMPROVED: do not show dead symlink as dir
* FIXED: do not return exe filetype when mode === -1
* MOVED: test files into __tests__ subdir
* FIXED: did show 0 file length for broken symlinks
* IMPROVED: show symlink title when hovering a symlink
* FIXED: use error color for broken symlinks on selected row
* FIXED: when copying a link, copy target, not file, fixes #91
* CLEANED-UP: removed not needed promise wrappers
* ADDED: Fs.options to specify fs-specific options
* FIXED: do not refresh dest cache on local since the watcher will do it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Filesystem invalid This doesn't seem right macOS
Projects
None yet
Milestone
release 2.3.0
Development

Successfully merging a pull request may close this issue.

Fix copy symlink warpdesign/react-explorer
1 participant
@warpdesign