Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADDED: feedback if terminal could not be started fixes #186 #190

Merged
merged 1 commit into from Nov 2, 2020
Merged

ADDED: feedback if terminal could not be started fixes #186 #190

merged 1 commit into from Nov 2, 2020

Conversation

warpdesign
Copy link
Owner

  • show an alert if testing the terminal doesn't work (preferences dialog)
  • show a warning toast if terminal could not be opened in active directory
  • do not attempt to open a terminal if directory could not be displayed
  • fixes Cannot open the terminal #186, regression introduced when upgrading to Electron 9

@warpdesign warpdesign merged commit e161ddf into master Nov 2, 2020
@warpdesign warpdesign deleted the add-feedback-if-test-terminal-fails branch November 2, 2020 10:16
@warpdesign warpdesign mentioned this pull request Nov 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot open the terminal
1 participant
@warpdesign