BUMPED: Electron to v19

.github/workflows/github-actions-tests.yml

@@ -0,0 +1,42 @@
+name: Cypress & Jest CI
+on: [push]
+jobs:
+  test:
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: [14.x]
+        os: [ubuntu-latest, macos-latest]
+        experimental: [false]
+        # include:
+        #   - os: windows-latest
+        #     experimental: true
+    runs-on: ${{ matrix.os }}
+    continue-on-error: ${{ matrix.experimental }}
+    defaults:
+      run:
+        working-directory: ./e2e
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          persist-credentials: false
+
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: 'npm'
+      - name: Install node_modules
+        working-directory: ./
+        run: npm ci
+      - name: Install e2e node_modules
+        run: npm ci
+      - name: Build E2E version
+        run: npm run build
+      - name: Run & wait for server
+        run: npm run server & npx wait-on http://localhost:8080
+      - name: Cypress tests
+        run: npm run cypress:run --config video=false
+      - name: Integration tests
+        working-directory: ./
+        run: npm test

.gitignore

@@ -4,4 +4,5 @@ dist-e2e/
 .DS_Store
 build/
 e2e/build-e2e/
+e2e/cypress/screenshots/
 public

.swcrc

@@ -0,0 +1,9 @@
+{
+    "jsc": {
+      "parser": {
+        "syntax": "typescript",
+        "tsx": true,
+        "decorators": true
+      }
+    }
+  }

e2e/cypress.config.ts

@@ -0,0 +1,10 @@
+import { defineConfig } from 'cypress';
+
+export default defineConfig({
+    e2e: {
+        setupNodeEvents(on, config) {
+            // implement node event listeners here
+        },
+        specPattern: 'cypress/e2e/**/*.spec.{js,jsx,ts,tsx}',
+    },
+});

e2e/cypress/integration/menu.accelerators.spec.ts → e2e/cypress/e2e/menu.accelerators.spec.ts

@@ -74,7 +74,7 @@ describe('combo hotkeys', () => {
         // no selection: triggering fake combo should not show toast message
         cy.triggerFakeCombo('CmdOrCtrl+Shift+C');
 
-        cy.get(`.${Classes.TOAST}`).should('not.be.visible');
+        cy.get(`.${Classes.TOAST}`).should('not.exist');
 
         cy.get('@copySelectedItemsPath').should('be.calledWith', caches[0], false);
     });
@@ -120,7 +120,7 @@ describe('combo hotkeys', () => {
 
         // wait for dialog to be closed otherwise
         // it could still be visible in next it()
-        cy.get('.shortcutsDialog').should('not.be.visible');
+        cy.get('.shortcutsDialog').should('not.exist');
     });
 
     it('should open prefs dialog', () => {
@@ -133,7 +133,7 @@ describe('combo hotkeys', () => {
 
         // wait for dialog to be closed otherwise
         // it could still be visible in next it()
-        cy.get('.shortcutsDialog').should('not.be.visible');
+        cy.get('.shortcutsDialog').should('not.exist');
     });
 
     it('should reload file view', () => {

e2e/cypress/integration/toolbar.spec.ts → e2e/cypress/e2e/toolbar.spec.ts

@@ -40,23 +40,15 @@ describe('toolbar', () => {
         cy.get('#view_0 [data-cy-path]').invoke('val', '/').focus();
     });
 
-    it('nav buttons are disabled', () => {
+    it('nav buttons should be disabled', () => {
         cy.get('#view_0 [data-cy-backward]').should('be.disabled');
         cy.get('#view_0 [data-cy-forward]').should('be.disabled');
 
         cy.get('#view_1 [data-cy-backward]').should('be.disabled');
         cy.get('#view_1 [data-cy-forward]').should('be.disabled');
     });
 
-    it('type path and enter calls cd', () => {
-        cy.get('#view_0 [data-cy-path]').type('/other_folder{enter}');
-
-        cy.get('@stub_cd0').should('be.called');
-
-        cy.get('.data-cy-alert').should('be.visible').find('.bp3-button').click();
-    });
-
-    it('type path and escape clears path with previous value', () => {
+    it('should restore previous input value when typing a new path and pressing escape', () => {
         cy.get('#view_0 [data-cy-path]').as('input').invoke('val').as('previous_value');
 
         cy.get('@input').type('/sdfdsgsdg{esc}');
@@ -68,7 +60,7 @@ describe('toolbar', () => {
         cy.get('@stub_cd0').should('not.be.called');
     });
 
-    it('type non valid path should show alert then focus input', () => {
+    it('should show an alert then focus input when typing a non valid path', () => {
         cy.get('#view_0 [data-cy-path]').type(':{enter}');
 
         cy.get('.data-cy-alert').should('be.visible').find('.bp3-button').click();
@@ -78,14 +70,14 @@ describe('toolbar', () => {
         cy.get('@stub_cd0').should('be.called');
     });
 
-    it('path should get updated when fileState is updated', () => {
+    it('should update the paht when the fileState is updated', () => {
         cy.window().then((win) => {
             win.appState.winStates[0].views[0].caches[0].updatePath('/newPath');
             cy.get('#view_0 [data-cy-path]').should('have.value', '/newPath');
         });
     });
 
-    it('clicking on reload should reload path', () => {
+    it('should reload path when clicking on reload button', () => {
         cy.get('#view_0 .data-cy-reload').click();
 
         cy.get('@stub_reload0').should('be.called');

e2e/cypress/mocks/process.js

@@ -6,4 +6,7 @@ module.exports = {
         chrome: 'cypress chrome',
         electron: 'cypress electron',
     },
+    env: {
+
+    }
 };

e2e/cypress/support/e2e.ts

@@ -0,0 +1,20 @@
+// ***********************************************************
+// This example support/e2e.ts is processed and
+// loaded automatically before your test files.
+//
+// This is a great place to put global configuration and
+// behavior that modifies Cypress.
+//
+// You can change the location of this file or turn off
+// automatically serving support files with the
+// 'supportFile' configuration option.
+//
+// You can read more here:
+// https://on.cypress.io/configuration
+// ***********************************************************
+
+// Import commands.js using ES2015 syntax:
+import './commands';
+
+// Alternatively you can use CommonJS syntax:
+// require('./commands')