Upgrade MobX remove decorators #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated mobx/mobx-react to v6 (removed outdated mobx-react-devtools) - removed every mobx & blueprintjs decorators I left experimentalDecorators in tsconfig/swrc for now since some decorators remain: - withMenuAccelerators - needsConnection - canTimeout (unused)
Note that `observableRequiresReaction` is still set to false: when enabling it, lots of warnings are reported because we access observable properties inside constructors. Maybe this code could be improved: I'm not sure wrapping observable access withing constructors using action() is a good idea since we are not modifying any state, only reading it.
warpdesign
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: blueprintjs still has lots of deprecated components before being able to upgrade to v4.