Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FsLocal.access: use async fs.access instead of incorrect fs.statSync #289

Merged
merged 1 commit into from Nov 14, 2022

Conversation

warpdesign
Copy link
Owner

@warpdesign warpdesign commented Nov 14, 2022

There is no need to call fs.stat to check the existence of a file/dir, especially not sync version.

Use async version of fs.access instead.

Note that there are other calls that should be fixed too.

Fixes #130

@warpdesign warpdesign merged commit b55117f into master Nov 14, 2022
@warpdesign warpdesign deleted the fslocal-rewrite-exists branch November 14, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite FsLocal.exists
1 participant