-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Added my Warp theme: dmilith #26
Conversation
foreground: '#bbbbbb' # The foreground color. | ||
background: '#001000' # Terminal background color | ||
|
||
background_image: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you comment this section out and also include a comment with a link to where someone could download the picture?
Similar to here: https://github.com/warpdotdev/themes/blob/main/warp_bundled/dark_city.yaml#L7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, just the background image section not foreground and background haha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey dmilith,
Thanks for opening this PR and adding a new theme. You're the first PR with a custom background image included. We aren't able to include the image because of licensing and also because we're trying to keep the repo size as small as possible.
Could you remove the background image from the PR but add a comment in the yaml with a link to where people could download it?
Sorry that it took so long to get back to you!
@dmilith Any updates on the background image comment above? We'd really like to merge this and add it to the https://github.com/daltonmenezes/aura-theme repo for others to enjoy. |
@dannyneira The image was taken from the free image source. If you want to save the colours, just drop the image background. (Support for the transparent terminal in Warp would be better than this) |
@dmilith can you remove the standard/dmilith_bg.jpg file and then we'll go ahead and merge it. Thanks again! |
Pull Request Template
Discord username (optional)
dmilith#1284
If you're in our Discord server please include your formatted like so: elvis#4747.
This is so we can give you the Contributor Discord role.
Note: It must be labelled like so: username#4747 (make sure to include the #XXXX).
Name of theme
dmilith
Please include the name of the theme.
How Has This Been Tested?
Have your run the python script?