Reject empty names for dashboards (re getredash#76)

client/app/pages/dashboards/edit-dashboard-dialog.html

@@ -4,7 +4,7 @@ <h4 class="modal-title">Edit: {{$ctrl.dashboard.name}}</h4>
 </div>
 <div class="modal-body">
   <p>
-    <input type="text" class="form-control" placeholder="Dashboard Name" ng-model="$ctrl.dashboard.name">
+    <input type="text" class="form-control" placeholder="Dashboard Name" ng-model="$ctrl.dashboard.name" required>
   </p>
 
   <div gridster="$ctrl.gridsterOptions" ng-if="$ctrl.items | notEmpty">

redash/handlers/dashboards.py

@@ -4,6 +4,7 @@
 from flask import request, url_for
 from flask_restful import abort
 from funcy import distinct, project, take
+from sqlalchemy.exc import IntegrityError
 from sqlalchemy.orm.exc import StaleDataError
 
 from redash import models, serializers
@@ -148,7 +149,8 @@ def post(self, dashboard_slug):
             models.db.session.commit()
         except StaleDataError:
             abort(409)
-
+        except IntegrityError:
+            abort(400)
         result = dashboard.to_dict(with_widgets=True, user=self.current_user)
         return result
 

redash/models.py

@@ -1162,7 +1162,7 @@ class Dashboard(ChangeTrackingMixin, TimestampMixin, BelongsToOrgMixin, db.Model
     org_id = Column(db.Integer, db.ForeignKey("organizations.id"))
     org = db.relationship(Organization, backref="dashboards")
     slug = Column(db.String(140), index=True, default=generate_slug)
-    name = Column(db.String(100))
+    name = Column(db.String(100), db.CheckConstraint("name<>''", name="dashboard_name_c"))
     user_id = Column(db.Integer, db.ForeignKey("users.id"))
     user = db.relationship(User)
     # TODO: The layout should dynamically be built from position and size information on each widget.