UI fixes for https://github.com/mozilla/redash/pull/293 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(incorporates: show data source type when no doc link present (re getredash#46))
Still can not use unpublished queries on dashboards.
addresses issue Madalin found that allows a click off the dialog box to close it without resetting the textbox
but don’t name a table abcdefghijklmnop.
I tried to make `JSON.stringify(this.visualization.options.columnMapping)` a variable to avoid repeating it, but if I make it a `let` the linter throws an error and if I make it a `const` then it doesn’t change with the UI and the logic doesn’t work. :( updated based on PR comments
Makes the _v of the schema browser toggle into a configurable string per data source. It is not required and if it is not filled in the toggle will not appear in the schema browser.
…bel tag to data queries select.
washort
force-pushed
the
toggle-autocomplete-282
branch
3 times, most recently
from
7404019
to
8fd9886
Compare
washort
pushed a commit
that referenced
this pull request
Jun 5, 2019
* Dashboard grid React migration * Updated tests * Fixes comments * One col layout * Tests unskipped * Test fixes * Test fix * AutoHeight feature * Kebab-cased * Get rid of lazyInjector * Replace react-grid-layout with patched fork to fix performance issues * Fix issue with initial layout when page has a scrollbar * Decrease polling interval (500ms is too slow) * Rename file to match it's contents * Added some notes and very minor fixes * Fix Remove widget button (should be visible only in editing mode); fix widget actions menu * Fixed missing grid markings * Enhanced resize handle * Updated placeholder color * Render DashboardGrid only when dashboard is loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues in the UI for mozilla#293 which showed up when decreasing the browser window width. This basically moves the "Format query" and a "Enable/Disable autocomplete" option to a new small dropdown.