Fix: added JSON parsing of the Graphite settings #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
added a commit
that referenced
this pull request
Feb 25, 2014
Fix: added JSON parsing of the Graphite settings
christophervalles
pushed a commit
to hailocab/redash
that referenced
this pull request
May 8, 2014
Fix: added JSON parsing of the Graphite settings
washort
pushed a commit
to washort/redash
that referenced
this pull request
Dec 13, 2017
addresses issue Madalin found that allows a click off the dialog box to close it without resetting the textbox
washort
pushed a commit
to washort/redash
that referenced
this pull request
Jan 8, 2018
addresses issue Madalin found that allows a click off the dialog box to close it without resetting the textbox
washort
pushed a commit
to washort/redash
that referenced
this pull request
Jan 9, 2018
addresses issue Madalin found that allows a click off the dialog box to close it without resetting the textbox
washort
pushed a commit
to washort/redash
that referenced
this pull request
Apr 30, 2018
addresses issue Madalin found that allows a click off the dialog box to close it without resetting the textbox
washort
pushed a commit
to washort/redash
that referenced
this pull request
May 31, 2018
addresses issue Madalin found that allows a click off the dialog box to close it without resetting the textbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using Python object for settings so no parsing was needed, since moving to env variables we need to parse the JSON object.